Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evm data sourcing #911

Merged
merged 13 commits into from
Feb 20, 2024
Merged

evm data sourcing #911

merged 13 commits into from
Feb 20, 2024

Conversation

candida-d
Copy link
Member

@candida-d candida-d commented Feb 5, 2024 •
edited
Loading

Closes #895

@candida-d candida-d linked an issue Feb 5, 2024 that may be closed by this pull request
EVM oracles #895
Closed
@candida-d candida-d marked this pull request as ready for review February 8, 2024 17:24
@candida-d candida-d requested a review from edd as a code owner February 8, 2024 17:24
daniel1302
daniel1302 reviewed Feb 13, 2024
View reviewed changes
Copy link
Contributor

@daniel1302 daniel1302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think sourceChain Id is in wrong place, and also proposal for external oracles changed a bit. I will share with you example market proposals

docs/tutorials/proposals/new-market-proposal.md Outdated Show resolved Hide resolved
@candida-d candida-d merged commit 1843a98 into main Feb 20, 2024
1 check passed
@candida-d candida-d deleted the 895-l2-oracles branch February 20, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang left review comments

@daniel1302 daniel1302 daniel1302 left review comments

@edd edd Awaiting requested review from edd edd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EVM oracles
3 participants
@candida-d @daniel1302 @jeremyletang